-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
CircleCI default behavior running html-noplot when no example is modified #10943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Questions here: Any example for situations when tests pass but examples fails (except for HTTP errors)? I can't recall such situation in the past year. Maybe we should rely on the tests to ensure the correctness of the code? |
In PR #10700, CircleCI tests are OK but I think examples/covariance/plot_outlier_detection.py should have failed because I removed the |
@albertcthomas Thanks for the example. I suppose we should blame the example of using |
PR #10700 might not be a good example after all because some examples have been modified and in such a case I think Circle only tests the modified examples and not the other ones (including plot_outlier_detection.py). But is this the intended behavior? Event if this would mean that we could merge a PR breaking an example whereas the full build of the doc would have revealed the problem. |
This was done like this in order for PR CIs to finish quicker as @qinhanmin2014 was saying. This is not perfect but covers very well the 95% of cases. This is not really a problem because master always does a full build, so in the rare case when a change to an estimator does break an example, master fails and we ask nicely the original author of the PR to fix it. FYI, you can add I am going to close this one, feel free to reopen if you disagree or can think of a better approach. |
thanks @lesteve. This answered my question and helped me understand the intended behavior of Circle which can be useful when reviewing or working on PRs :). Thanks again @qinhanmin2014. |
Isn't it bad that CircleCI only runs html-noplot when no example is modified? Changing the code of an estimator can break some examples but CircleCI won't fail with html-noplot.
The text was updated successfully, but these errors were encountered: