-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
Complete deprecations finishing in 0.21 #11992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Same comment as in #11991 (comment) ... |
I agree, let's wait for the final release, but then hurray! |
(if I have time I'll do this just for the satisfaction of deleting so much code, as usual ;) |
Yes, but to help it get merged in a reasonable time frame, maybe split up
the pr this time.
|
hopefully it will be smaller this time around... |
so I'm going through most of these. I think the SGDClassifier max_int/n_iter/tol thing maybe should go in its own PR. possibly the train_size/test_size thing, too? |
I started on everything but the train_size/test_size thing. |
Maybe a reviewer can start with #12238 which is the biggest but should be a straight-forward removal of lots of stuff. |
I can split up #12238 further if you like, though. |
a lot of the FeatureHasher tests assume the existence of |
Part of #11992. These were all the things that seemed pretty straight-forward. It's actually a bit bulky but should still be easy to review, hopefully.
I think this is done. |
The text was updated successfully, but these errors were encountered: