Update maintainer.rst for new maintainers and their new permissions. #12790
Labels
Comments
|
What privilege do you want? Is it enough to log in with your github account? |
|
I don't really think I need any new privileges. I just don't want me or anybody else to cause the same trouble as it happened on circle-ci. Or I can try to login to those platforms, and make sure to document it if something happens. That means I need to give a heads up before doing it, just in case :P. |
|
These things are meaningful for very few people, so I'm not sure whether it's good to include them in the doc. |
|
We have had weirdness around these things before, but I'm not convinced
that documenting it will reduce the rate of incidence. Fwiw I've found
Travis to be most sensibly behaved, so it's probably safe to authorise
|
|
Ok then. Logged into travis as well. Hope nothing bad happens :) Closing the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In light of the recent and previous incidents (#11550, #12782) where a maintainer logs into circle-ci and accidentally adds a deployment key to the sklearn's repo (resulting in circle-ci deploy step failing), I think it makes sense to have a section in the maintainer.rst and guide a newcomer like me on how to setup their accounts with the related platforms such as travis, circle-ci, etc.
Right now I'm trying to login to travis, and it's asking for some permissions and now I'm too scared to hit "Authorize travis-ci" button, and couldn't find any relevant info in the docs.
I'm happy to put a PR together after hearing your experiences on each of those platforms we use (and THEN setup my account in them).
The text was updated successfully, but these errors were encountered: