Skip to content

NMF and non_negative_factorization have inconsistent default init #12988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zjpoh opened this issue Jan 16, 2019 · 0 comments · Fixed by #12989
Closed

NMF and non_negative_factorization have inconsistent default init #12988

zjpoh opened this issue Jan 16, 2019 · 0 comments · Fixed by #12989

Comments

@zjpoh
Copy link
Contributor

zjpoh commented Jan 16, 2019

Description

NMF and non_negative_factorization have inconsistent default init. NMF has init=None while non_negative_factorization has init='random'.

See #11667

As suggested, we could change the default in non_negative_factorization with a deprecation process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG] NMF and non_negative_factorization have inconsistent default init zjpoh/scikit-learn
1 participant
@zjpoh