Skip to content

Check consistency / correctness of 1d input and n-d input for all estimators #1678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amueller opened this issue Feb 13, 2013 · 3 comments
Closed

Check consistency / correctness of 1d input and n-d input for all estimators #1678

amueller opened this issue Feb 13, 2013 · 3 comments
Labels
Easy Well-defined and straightforward way to resolve Enhancement

Comments

@amueller
Copy link
Member

The handling of 1d input should be consistent in all estimators. I think currently 1d X is assumed to be of shape (1, n_features) - and even that might fail sometimes. That needs to be checked and needs to be consistent across all estimators.

Also, all estimators that don't support nd-input (I'm not sure any do or should do?) need to raise an appropriate error.
@amueller
Copy link
Member Author

Also compare #1549. I think that asks to interpret 1d input the other way around. I guess we should find out what estimators do atm before changing any behavior.

@arjoly
Copy link
Member

arjoly commented Mar 10, 2013

It might also be interesting to look at #1750.

@amueller amueller mentioned this issue Mar 31, 2013
Closed
@arjoly
Copy link
Member

arjoly commented May 11, 2014

it's done in #2293

@arjoly arjoly closed this as completed May 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy Well-defined and straightforward way to resolve Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amueller @arjoly