Fix 0.23 whats_new entries #17057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

adrinjalali opened this issue Apr 27, 2020 · 3 comments · Fixed by #17066

Labels

Milestone

Member

adrinjalali commented Apr 27, 2020

Towards #17010.

Cleaning ups to whats_new.

Some cases which need fixes:

Not sure:

BUG Ignores tags when estimator is a class in parametrize_with_checks (BUG Ignores tags when estimator is a class in parametrize_with_checks #16709) @thomasjpfan
FIX Expose SelectorMixin through sklearn/feature_selection/ (FIX Expose SelectorMixin through sklearn/feature_selection/ #16132) @jnothman @rth
FIX Explicit conversion of ndarray to object dtype. ([MRG] Explicit conversion of ndarray to object dtype #15832) @jnothman
BUG Returns only public estimators in all_estimators ([MRG] BUG Returns only public estimators in all_estimators #15380) @thomasjpfan

Need entry:

BUG Fixes HistGradientBoosting when warm_start is on + early_stopping is on + no validation (FIX Fixes HistGradientBoosting when warm_start is on + early_stopping is on + no validation #16663) @thomasjpfan
ENH Add check for non binary variables in OneHotEncoder. (ENH Add check for non binary variables in OneHotEncoder. #16585) @cmarmo
ENH Reduce memory footprint in MLP when shuffle activated (Reduce memory footprint when using stochastic optimizers with shuffle activated #14075) @glemaitre @rth @jnothman
FIX avoid division by 0 warning in LabelPropagation (Label spreading bug fix #15946) @jnothman @glemaitre
xfail related PRs.

adrinjalali added this to the 0.23 milestone

adrinjalali added the Documentation label

adrinjalali mentioned this issue

DOC cleaning up to 0.23/whats new #17015

Merged

NicolasHug mentioned this issue

[MRG] DOC kwonly section in whatsnew #17059

Merged

Member

thomasjpfan commented Apr 27, 2020

BUG Ignores tags when estimator is a class in parametrize_with_checks

Now that we are going to deprecated class support. I do not think we need this in whats new.

thomasjpfan mentioned this issue

DOC Add whats new for missing PRs #17066

Merged

Member

jnothman commented Apr 28, 2020

Not going to do #15832.

jnothman closed this as completed in #17066

Member Author

adrinjalali commented Apr 28, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment