Skip to content

Refactor accuracy_score #1748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amueller opened this issue Mar 6, 2013 · 5 comments
Closed

Refactor accuracy_score #1748

amueller opened this issue Mar 6, 2013 · 5 comments
Labels
Easy Well-defined and straightforward way to resolve Enhancement

Comments

@amueller
Copy link
Member

amueller commented Mar 6, 2013

I think it should be computed in terms of zero_one_loss to avoid code duplication.

@arjoly
Copy link
Member

arjoly commented Mar 7, 2013

It might be better to do the opposite. In multilabel classification, there is the jaccard similarity score that is also called accuracy and is another type of averaging to compute the accuracy.

@amueller
Copy link
Member Author

amueller commented Mar 7, 2013

I thought the zero_one_loss was more general as we can get the unnormalized version.
As these are only internals, we can always change them. I was just a bit confused that there are two basically identical implementations that are >20 lines that only differ by a sign as far as I can tell.

@arjoly
Copy link
Member

arjoly commented Mar 7, 2013

I will submit a patch. I would like to add the normalize option to the accuracy_score.
Is it ok for you?

@amueller
Copy link
Member Author

amueller commented Mar 7, 2013

sure! thanks :)

@arjoly
Copy link
Member

arjoly commented Mar 27, 2013

Fix in #1750

@arjoly arjoly closed this as completed Mar 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy Well-defined and straightforward way to resolve Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants