Skip to content

Investigate and fix performances in *_tree dependent algorithms due to multiple input validation. #18749

Closed
@cmarmo

Description

@cmarmo

Related to @ogrisel comment.

An input check has been added in _binary_tree.pxi

self.data_arr = check_array(data, dtype=DTYPE, order='C')

Some other were already there

X = check_array(X, dtype=DTYPE, order='C')

X = check_array(X, dtype=DTYPE, order='C')

...

The context manager should be used to wrap the calls to BallTree from other classes in scikit-learn that have already validated there input data to avoid duplicating this check (see #18727 for a similar procedure).

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions