-
-
Notifications
You must be signed in to change notification settings - Fork 26.2k
Closed
Labels
Needs Decision - CloseRequires decision for closingRequires decision for closingPerformancemodule:tree
Description
An input check has been added in _binary_tree.pxi
scikit-learn/sklearn/neighbors/_binary_tree.pxi
Line 1052 in 61beb3b
self.data_arr = check_array(data, dtype=DTYPE, order='C') |
Some other were already there
scikit-learn/sklearn/neighbors/_binary_tree.pxi
Line 1335 in 61beb3b
X = check_array(X, dtype=DTYPE, order='C') |
scikit-learn/sklearn/neighbors/_binary_tree.pxi
Line 1472 in 61beb3b
X = check_array(X, dtype=DTYPE, order='C') |
...
The context manager should be used to wrap the calls to BallTree from other classes in scikit-learn that have already validated there input data to avoid duplicating this check (see #18727 for a similar procedure).
Metadata
Metadata
Assignees
Labels
Needs Decision - CloseRequires decision for closingRequires decision for closingPerformancemodule:tree