Skip to content

MAINT Move PolynomialFeatures to _polynomial.py #19574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lorentzenchr opened this issue Feb 26, 2021 · 10 comments · Fixed by #19611
Closed

MAINT Move PolynomialFeatures to _polynomial.py #19574

lorentzenchr opened this issue Feb 26, 2021 · 10 comments · Fixed by #19611
Assignees
Labels
Easy Well-defined and straightforward way to resolve module:preprocessing

Comments

@lorentzenchr
Copy link
Member

A little maintenance task: Move class PolynomialFeatures from _data.py to _polynomial.py and tests likewise.
See #18368 (comment).

@lorentzenchr
Copy link
Member Author

@thomasjpfan @glemaitre If you are ok with it, I'll label it as "help wanted".

@thomasjpfan
Copy link
Member

Okay, I am okay with this to be "help wanted". I also think it would be nice to move the test related to PolynomialFeatures from test_data into its own `test_polynomial.py" file.

@lorentzenchr lorentzenchr added Easy Well-defined and straightforward way to resolve help wanted labels Mar 1, 2021
@LSturtew
Copy link
Contributor

LSturtew commented Mar 1, 2021

I would like to work on this task.

@dachosen1
Copy link
Contributor

Is still being worked on?

@avigupta2612
Copy link
Contributor

Working on this..

@lorentzenchr
Copy link
Member Author

@LSturtew You was first, so you should have the chance to open a PR. Please say if you need help or if other contributors might help you.

@avigupta2612
Copy link
Contributor

I really apologise @lorentzenchr and @LSturtew for this,
I saw your message just seconds after I pushed the PR.

@lorentzenchr
Copy link
Member Author

@LSturtew Do you still want to do this PR or is it ok for you to look out for another open issue?
2 pieces of advice for the future: You can write "take" to assign you to an issue. Second, it helps if you open a PR very soon to show that you are actually working in the issue.

@LSturtew
Copy link
Contributor

LSturtew commented Mar 4, 2021

I'm sorry it would be my first time contributing to this project, so I was not aware of that I could just take the issue.

@cmarmo
Copy link
Contributor

cmarmo commented Mar 5, 2021

Hi @LSturtew if you are interested in starting contributing there are some issues used during the sprints quite good for first contributors: eg #19334 still needs two warnings to be fixed. Feel free to comment there if this could fit you. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy Well-defined and straightforward way to resolve module:preprocessing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants