Skip to content

Random failure in test_estimators[OutputCodeClassifier(estimator=LogisticRegression(C=1))-check_complex_data] #20218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ogrisel opened this issue Jun 7, 2021 · 2 comments · Fixed by #20221
Closed

Random failure in test_estimators[OutputCodeClassifier(estimator=LogisticRegression(C=1))-check_complex_data] #20218

ogrisel opened this issue Jun 7, 2021 · 2 comments · Fixed by #20221
Labels
Build / CI module:test-suite everything related to our tests

Comments

@ogrisel
Copy link
Member

ogrisel commented Jun 7, 2021 •
edited
Loading

I merged #20192 #20193 too quickly and now we have random failure in check_complex_data for OutputCodeClassifier in the main branch.

The ValueError is not always raised for complex data for this estimator. It seems to be more frequent on Windows but can also happen on Linux...
@ogrisel
Copy link
Member Author

ogrisel commented Jun 7, 2021

Example failure:

https://dev.azure.com/scikit-learn/scikit-learn/_build/results?buildId=29157&view=logs&j=49f70b07-9eec-54da-4186-5a4fa38d566e&t=4acaf5ee-4b96-54ff-292e-f87053ca41e5

@ogrisel ogrisel added Build / CI module:test-suite everything related to our tests and removed Bug: triage labels Jun 7, 2021
@ogrisel ogrisel mentioned this issue Jun 7, 2021
Closed
@ogrisel
Copy link
Member Author

ogrisel commented Jun 7, 2021 •
edited
Loading

Actually OutputCodeClassifier was changed earlier in #20193 and I found occurrences of failures in main after that merge and before #20192 was merged.

@ogrisel ogrisel mentioned this issue Jun 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Build / CI module:test-suite everything related to our tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX make check_complex_data deterministic ogrisel/scikit-learn
1 participant
@ogrisel