Skip to content

On Windows utils\tests\test_cython_templating.py unit-test is failing #20996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gaborkertesz opened this issue Sep 9, 2021 · 0 comments · Fixed by #20997
Closed

On Windows utils\tests\test_cython_templating.py unit-test is failing #20996

gaborkertesz opened this issue Sep 9, 2021 · 0 comments · Fixed by #20997

Comments

@gaborkertesz
Copy link
Contributor

gaborkertesz commented Sep 9, 2021

Describe the bug

On x64 win10 and arm64win win10 the following unit-test is failing:
sklearn\utils\tests\test_cython_templating.py

        for filename in base_dir.glob("**/*.tp"):
            filename = filename.relative_to(base_dir.parent)
            # From "path/to/template.p??.tp" to "path/to/template.p??"
            filename_wo_tempita_suffix = filename.with_suffix("")
>           assert str(filename_wo_tempita_suffix) in ignored_files
E           AssertionError: assert 'sklearn\\linear_model\\_sag_fast.pyx' in ['*.pyc', '*.so', '*.pyd', '*.pyx', '*~', '.#*', ...]
E            +  where 'sklearn\\linear_model\\_sag_fast.pyx' = str(WindowsPath('sklearn/linear_model/_sag_fast.pyx'))

Steps/Code to Reproduce

pytest sklearn/utils

Expected Results

933 passed, 193 skipped, 159 warnings in 48.15s

Actual Results

1 failed, 932 passed, 193 skipped, 159 warnings in 35.64s

Versions

System:
python: 3.9.7 (tags/v3.9.7:1016ef3, Aug 30 2021, 20:19:38) [MSC v.1929 64 bit (AMD64)]
executable: c:\kg\stuff\WoA\test\venv_dir\Scripts\python.exe
machine: Windows-10-10.0.19041-SP0

Python dependencies:
pip: 21.2.3
setuptools: 57.4.0
sklearn: 1.0.dev0
numpy: 1.21.2
scipy: 1.7.1
Cython: 0.29.24
pandas: None
matplotlib: None
joblib: 1.0.1
threadpoolctl: 2.2.0

Built with OpenMP: True

gaborkertesz added a commit to gaborkertesz/scikit-learn that referenced this issue Sep 9, 2021
Converting to string removed the windows compatible path.
gaborkertesz added a commit to gaborkertesz/scikit-learn that referenced this issue Sep 9, 2021
Converting to string removed the windows compatible path.
gaborkertesz added a commit to gaborkertesz/scikit-learn that referenced this issue Sep 23, 2021
Converting to string removed the windows compatible path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant