Skip to content

STY black format all existing python code #21045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
PSSF23 opened this issue Sep 14, 2021 · 2 comments
Closed

STY black format all existing python code #21045

PSSF23 opened this issue Sep 14, 2021 · 2 comments
Assignees
@PSSF23
Labels
Documentation

Comments

@PSSF23
Copy link
Contributor

PSSF23 commented Sep 14, 2021 •
edited
Loading

Describe the issue linked to the documentation

As it's required in the tests, why not to format existing code as well? Affected code:

  • sklearn/externals/*
  • examples/*
  • doc/tutorial/*

Suggest a potential alternative/fix

I'm not aware of other concerns for code formats and don't know if it is inappropriate for certain folders.
@PSSF23
Copy link
Contributor Author

PSSF23 commented Sep 14, 2021

Take

@PSSF23 PSSF23 mentioned this issue Sep 14, 2021
Closed
@glemaitre
Copy link
Member

sklearn/externals/*

These files are vendored. To minimize the diff, we keep it the style from the original source.

examples/* and doc/tutorial/*

We are awaiting to know if we go with 79 or 88 characters. One PR was already submitted:
#20502

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PSSF23 PSSF23

Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

STY black format all python code PSSF23/scikit-learn-stream
2 participants
@glemaitre @PSSF23