Skip to content

HTML representation of estimators: center the diagrams #21290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
reshamas opened this issue Oct 8, 2021 · 3 comments
Closed

HTML representation of estimators: center the diagrams #21290

reshamas opened this issue Oct 8, 2021 · 3 comments
Labels

Comments

@reshamas
Copy link
Member

reshamas commented Oct 8, 2021

Describe the issue linked to the documentation

The HTML representation of the pipeline is currently left-centered.

Suggest fix

Center the diagram.

References

#18305

Suggest a potential alternative/fix

No response

@thomasjpfan
Copy link
Member

thomasjpfan commented Oct 8, 2021

I considered centering while developing the diagrams and concluded that centering looking out of place in the jupyter ecosystem. All of the HTML representations from other libraries I have seen are left-justified.

What are the advantages you see for centering the diagram?

@reshamas
Copy link
Member Author

reshamas commented Oct 8, 2021

I think it's ok being left-justified in the notebook. At today's office hours, I believe the discussion was around having it centered in the documentation showing the visual diagrams.

@ogrisel What do you think?

@cmarmo cmarmo added the Needs Decision Requires decision label Sep 14, 2022
@glemaitre
Copy link
Member

I think this is just a matter of taste. Since we did not make the change since 3 years, I think this is fine. I think that we should prioritize improving the diagram themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants