Skip to content

Refactor metadata routing classes used in tests #23918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adrinjalali opened this issue Jul 16, 2022 · 3 comments
Closed

Refactor metadata routing classes used in tests #23918

adrinjalali opened this issue Jul 16, 2022 · 3 comments
Labels
Refactor Code refactor

Comments

@adrinjalali
Copy link
Member

The work related to metadata routing has introduced quite a few classes in the test files in order to test different functionalities and different cases.

Once we have advanced more in the implementation, we should refactor those classes, find common patterns, and clean them up, and maybe move some of them beside the other classes used in testing where the MinimalClassifier is also implemented.

Related to #22893
@github-actions github-actions bot added the Needs Triage Issue requires triage label Jul 16, 2022
This was referenced Jul 16, 2022
Open
Merged
@thomasjpfan thomasjpfan added Refactor Code refactor and removed Needs Triage Issue requires triage labels Jul 17, 2022
@haiatn
Copy link
Contributor

haiatn commented Jul 29, 2023

Did #22986 fix this? What else is there to do?

@adrinjalali
Copy link
Member Author

#26894 worked towards this, @thomasjpfan is the code now at a state where you'd consider this issue fixed?

@thomasjpfan
Copy link
Member

Yup, I think we can consider this issue fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Refactor Code refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adrinjalali @thomasjpfan @haiatn