Skip to content

ledoit_wolf_shrinkage is not documented but still publicly available #25252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
glevv opened this issue Dec 29, 2022 · 1 comment · Fixed by #25255
Closed

ledoit_wolf_shrinkage is not documented but still publicly available #25252

glevv opened this issue Dec 29, 2022 · 1 comment · Fixed by #25255
Labels
Documentation

Comments

@glevv
Copy link
Contributor

glevv commented Dec 29, 2022 •
edited
Loading

Describe the issue linked to the documentation

ledoit_wolf_shrinkage is not documented, but publicly available.

See discussion in #24870 (#24870 (comment))

Suggest a potential alternative/fix

It should be either documented or made private with deprecation
@glevv glevv added Documentation Needs Triage Issue requires triage labels Dec 29, 2022
@glemaitre
Copy link
Member

I was looking at a PR linked to oas and we probably should not deprecate this function but instead document it. It could become handy.

@glemaitre glemaitre removed the Needs Triage Issue requires triage label Dec 30, 2022
@glevv glevv mentioned this issue Dec 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DOC Add ledoit_wolf_shrinkage reference to the public api glevv/scikit-learn
2 participants
@glemaitre @glevv