Skip to content

Use common loss module in gradient boosting #25964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
7 tasks done
lorentzenchr opened this issue Mar 24, 2023 · 2 comments · Fixed by #26278
Closed
7 tasks done

Use common loss module in gradient boosting #25964

lorentzenchr opened this issue Mar 24, 2023 · 2 comments · Fixed by #26278
Labels
Meta-issue General issue associated to an identified list of tasks module:ensemble

Comments

@lorentzenchr
Copy link
Member

lorentzenchr commented Mar 24, 2023 •
edited
Loading

GradientBoostingClassifier and GradientBoostingRegressor are not yet migrated to the new common (private) loss function module, see #15123. The steps needed are:
@github-actions github-actions bot added the Needs Triage Issue requires triage label Mar 24, 2023
@lorentzenchr
Copy link
Member Author

This time, I'll try small incremental PRs.

I could need some help deciding on how to tackle the initialization of raw_predictions. Should it be 100% backwards compatible or are tiny deviations allowed, e.g. clip(.., 1e-7) vs clip(.., 1e-14).

This was referenced Mar 24, 2023
Merged
Merged
Open
@thomasjpfan thomasjpfan added module:ensemble Meta-issue General issue associated to an identified list of tasks and removed Needs Triage Issue requires triage labels Apr 6, 2023
This was referenced Apr 21, 2023
Merged
Merged
@lorentzenchr lorentzenchr mentioned this issue Aug 3, 2023
Closed
@lorentzenchr
Copy link
Member Author

Finally 🎉

@lorentzenchr lorentzenchr mentioned this issue Jan 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Meta-issue General issue associated to an identified list of tasks module:ensemble
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ENH replace loss module Gradient boosting lorentzenchr/scikit-learn
2 participants
@thomasjpfan @lorentzenchr