-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
RFC bump Cython minimum supported version to 3.0.8 #28259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
+1, since these are closed: |
Since this is only a build dependency I would be inclined to bump. |
+1 for using Cython>=3.0.8 as a build dependency. Should we milestone it for 1.5? |
If some of the PR above are bug fixes, then we would need to target for the bug fix release. |
I'll submit a PR to bump the min version. |
A bit confused. cython=3.0.8 doesn't seem to be on conda-forge: https://anaconda.org/conda-forge/cython/files However, two weeks ago the 3.0.8 build PR was merged: conda-forge/cython-feedstock#133 Opened this to ask: conda-forge/cython-feedstock#134 |
Seems like the files have been uploaded quite recently: |
Ah right I am reading the issue you opened so there was indeed an issue which was fixed. Now files have been uploaded and there is this small delay to wait. |
What do we do about anaconda main channel? (I have wanted to ditch that completely for a while). cython=3.0.6 is the latest there. |
Can we ignore them? |
I would love to. But a few of us insist on keeping main channel on the CI 😁 in #28284 I'm installing cython from pypi on those CI runs. |
Thank you, @adrinjalali. |
Currently we still have Cython 0.29.33 as our minimum Cython version. We may want to decide to bump our Cython requirement to Cython >= 3.0.8. I am +1 for this given that:
cimport
interfaces fromstd::algorithm
#27682 needs Cython >= 3main
branch: MAINT Directlycimport
interfaces fromstd::algorithm
#27682 (comment)The text was updated successfully, but these errors were encountered: