Skip to content

RFC bump Cython minimum supported version to 3.0.8 #28259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lesteve opened this issue Jan 25, 2024 · 12 comments · Fixed by #28284
Closed

RFC bump Cython minimum supported version to 3.0.8 #28259

lesteve opened this issue Jan 25, 2024 · 12 comments · Fixed by #28284

Comments

@lesteve
Copy link
Member

lesteve commented Jan 25, 2024

Currently we still have Cython 0.29.33 as our minimum Cython version. We may want to decide to bump our Cython requirement to Cython >= 3.0.8. I am +1 for this given that:

@github-actions github-actions bot added the Needs Triage Issue requires triage label Jan 25, 2024
@adrinjalali
Copy link
Member

+1, since these are closed:

@glemaitre
Copy link
Member

Since this is only a build dependency I would be inclined to bump.

@jjerphan
Copy link
Member

+1 for using Cython>=3.0.8 as a build dependency.

Should we milestone it for 1.5?

@glemaitre
Copy link
Member

If some of the PR above are bug fixes, then we would need to target for the bug fix release.

@adrinjalali
Copy link
Member

I'll submit a PR to bump the min version.

@adrinjalali
Copy link
Member

A bit confused. cython=3.0.8 doesn't seem to be on conda-forge: https://anaconda.org/conda-forge/cython/files

However, two weeks ago the 3.0.8 build PR was merged: conda-forge/cython-feedstock#133

Opened this to ask: conda-forge/cython-feedstock#134

@lesteve
Copy link
Member Author

lesteve commented Jan 26, 2024

Seems like the files have been uploaded quite recently:
https://anaconda.org/conda-forge/cython/files
I seem to remember there is some small delay (maybe 1-2 hours) between the upload and the fact they are visible by conda install

@lesteve
Copy link
Member Author

lesteve commented Jan 26, 2024

Ah right I am reading the issue you opened so there was indeed an issue which was fixed. Now files have been uploaded and there is this small delay to wait.

@adrinjalali
Copy link
Member

What do we do about anaconda main channel? (I have wanted to ditch that completely for a while).

cython=3.0.6 is the latest there.

@adrinjalali adrinjalali added Build / CI and removed Needs Triage Issue requires triage labels Jan 26, 2024
@jjerphan
Copy link
Member

What do we do about anaconda main channel?

Can we ignore them?

@adrinjalali
Copy link
Member

Can we ignore them?

I would love to. But a few of us insist on keeping main channel on the CI 😁 in #28284 I'm installing cython from pypi on those CI runs.

@jjerphan
Copy link
Member

Thank you, @adrinjalali.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants