You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Birch doesn't perform inplace operations (at least not on the input array), so the copy parameter is useless and should be deprecated. It's even detrimental because by default it makes a copy.
The only place where an inplace operation happens is in the update method of _CFSubcluster:
However, update is call in 2 places. The first one is in the _split_node function, but here we first create 2 new _CFSubcluster objects and so the update performs inplace operations on newly created data, so the input data is not modified. The second one is in the insert_cf_subcluster method of _CFNode but is only triggered if the subcluster has a child, which can only come from splitted subclusters (i.e. after _split_node), so again we're not modifying the input data.
The text was updated successfully, but these errors were encountered:
Birch
doesn't perform inplace operations (at least not on the input array), so thecopy
parameter is useless and should be deprecated. It's even detrimental because by default it makes a copy.The only place where an inplace operation happens is in the
update
method of_CFSubcluster
:scikit-learn/sklearn/cluster/_birch.py
Lines 315 to 320 in 11e8c21
However,
update
is call in 2 places. The first one is in the_split_node
function, but here we first create 2 new_CFSubcluster
objects and so theupdate
performs inplace operations on newly created data, so the input data is not modified. The second one is in theinsert_cf_subcluster
method of_CFNode
but is only triggered if the subcluster has a child, which can only come from splitted subclusters (i.e. after_split_node
), so again we're not modifying the input data.The text was updated successfully, but these errors were encountered: