Skip to content

⚠️ CI failed on Linux_nogil.pylatest_pip_nogil (last failure: Jun 10, 2024) ⚠️ #29189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
scikit-learn-bot opened this issue Jun 5, 2024 · 4 comments · Fixed by #29191
Labels
Needs Triage Issue requires triage

Comments

@scikit-learn-bot
Copy link
Contributor

scikit-learn-bot commented Jun 5, 2024

CI is still failing on Linux_nogil.pylatest_pip_nogil (Jun 10, 2024)
Unable to find junit file. Please see link for details.

@github-actions github-actions bot added the Needs Triage Issue requires triage label Jun 5, 2024
@lesteve
Copy link
Member

lesteve commented Jun 5, 2024

Now that we check build dependencies #29132, the numpy in nogil is too old, i.e. 1.24 and we want >=1.25.

I think this may be worth removing this historic nogil build given that a CPython 3.13 free-threaded will happen soonish, maybe a few weeks:

@lesteve
Copy link
Member

lesteve commented Jun 5, 2024

I opened #29191 to remove the nogil CPython 3.9 build.

@rgommers
Copy link
Contributor

rgommers commented Jun 5, 2024

once there is a Scipy wheel, it is up to us to add a CI build for CPython 3.13 free-threaded 😉.

@lesteve SciPy nightly wheels are available now. Our team for free-threaded CPython at Quansight Labs has bandwidth to help with this kind of task for scikit-learn (wheels, debugging, etc.) over the next months. If you want us to work on adding this new CI job, or contribute to thread-safety fixes or whatever, please don't hesitate to ask.

@lesteve
Copy link
Member

lesteve commented Jun 5, 2024

Yeah I have seen this, this is great! I think it will be more efficient if I add the CI job, because I am familiar with scikit-learn CI quirks, but I definitely will ask you or Nathan when needed.

FYI I opened a CPython 3.13 free-threaded WIP PR in joblib as well recently joblib/joblib#1589

@scikit-learn-bot scikit-learn-bot changed the title ⚠️ CI failed on Linux_nogil.pylatest_pip_nogil (last failure: Jun 05, 2024) ⚠️ ⚠️ CI failed on Linux_nogil.pylatest_pip_nogil (last failure: Jun 06, 2024) ⚠️ Jun 6, 2024
@scikit-learn-bot scikit-learn-bot changed the title ⚠️ CI failed on Linux_nogil.pylatest_pip_nogil (last failure: Jun 06, 2024) ⚠️ ⚠️ CI failed on Linux_nogil.pylatest_pip_nogil (last failure: Jun 07, 2024) ⚠️ Jun 7, 2024
@scikit-learn-bot scikit-learn-bot changed the title ⚠️ CI failed on Linux_nogil.pylatest_pip_nogil (last failure: Jun 07, 2024) ⚠️ ⚠️ CI failed on Linux_nogil.pylatest_pip_nogil (last failure: Jun 08, 2024) ⚠️ Jun 8, 2024
@scikit-learn-bot scikit-learn-bot changed the title ⚠️ CI failed on Linux_nogil.pylatest_pip_nogil (last failure: Jun 08, 2024) ⚠️ ⚠️ CI failed on Linux_nogil.pylatest_pip_nogil (last failure: Jun 09, 2024) ⚠️ Jun 9, 2024
@scikit-learn-bot scikit-learn-bot changed the title ⚠️ CI failed on Linux_nogil.pylatest_pip_nogil (last failure: Jun 09, 2024) ⚠️ ⚠️ CI failed on Linux_nogil.pylatest_pip_nogil (last failure: Jun 10, 2024) ⚠️ Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Triage Issue requires triage
Projects
None yet
3 participants