Skip to content

Add Python 3.13 development wheel #29292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
clin1234 opened this issue Jun 19, 2024 · 2 comments · Fixed by #29789
Closed

Add Python 3.13 development wheel #29292

clin1234 opened this issue Jun 19, 2024 · 2 comments · Fixed by #29789

Comments

@clin1234
Copy link

Describe the workflow you want to enable

Based on #29280, building sklearn on Python 3.13 succeeds and running pytest also succeeds. I want to help enable building and uploading wheels supporting 3.13 on PyPI

Describe your proposed solution

Since I'm very new in looking at CI files for this project, find someone willing to explain how wheel-building is triggered on GH.

Describe alternatives you've considered, if relevant

No response

Additional context

No response

@clin1234 clin1234 added Needs Triage Issue requires triage New Feature labels Jun 19, 2024
@lesteve lesteve added Build / CI and removed New Feature Needs Triage Issue requires triage labels Jun 19, 2024
@lesteve
Copy link
Member

lesteve commented Jun 19, 2024

Thanks for the issue and your help proposal, This was something I was wondering about whether we want to do it.

Can you say a few words about your use case out of interest, e.g. which kind of projects are you looking to test for, what kind of OS you are targeting, etc ...

I think Numpy already has a Python 3.13 wheel, so we would first need Scipy to have a scipy 3.13 wheel. Last time I checked they don't have a one, see https://anaconda.org/scientific-python-nightly-wheels/scipy/files. Maybe look in Scipy issue tracker if they have already an issue about this? Note that cp313-cp313t are actually Python 3.13 free-threaded wheels, if you want standard Python you want cp313-cp313.

Side-comment we should have soonish (~one hour) Python 3.13 free-threaded wheel, if https://github.com/scikit-learn/scikit-learn/actions/runs/9575818682 is successful 🤞 since I merged #29247.

If you are really feeling adventurous and want to test Python 3.13 as fast as possible you can already set-up your testing using Python 3.13 free-threaded and set PYTHON_GIL=1. Note that you may bump into weird unexpected issues that are only present in Python 3.13 free-threaded and not Python 3.13 vanilla Python.

@lesteve lesteve changed the title Add wheels for 3.13 Add Python 3.13 development wheel Jun 19, 2024
This was referenced Jun 19, 2024
clin1234 added a commit to clin1234/scikit-learn that referenced this issue Jun 19, 2024
clin1234 added a commit to clin1234/scikit-learn that referenced this issue Jun 19, 2024
@clin1234
Copy link
Author

gh-21000 added 3.13 wheels builds; new nightlies are building now and should upload to https://anaconda.org/scientific-python-nightly-wheels/scipy/ in the next 30 minutes or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants