-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
In gaussian_process/kernels.py, the Tanimoto kernel would be welcome #29507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for the report. But from your description it's not clear to me what you're intending to change. It seems to me writing a custom kernel is exactly designed for these cases. So closing as out of scope, but happy to reopen if more context is given. |
Could a scikit-learn hacker provide an implementation of the Tanimoto kernel? |
The Tanimoto kernel is for instances which are bitstrings. |
Please reopen this issue. |
There are some interesting kernels implemented in there: |
Describe the workflow you want to enable
Here is a formula:
xy / (||x||^2 + ||y||^2 - xY)
Describe your proposed solution
In the context of Gaussian Process Regression, maybe this should be multiplied by the variance,
so the formula becomes:
v * (xy / (||x||^2 + ||y||^2 - xY))
Describe alternatives you've considered, if relevant
Implement a new kernel myself, but since implementation of a kernel requires much more than just
a K method (evaluate the kernel), I find this way too dangerous.
Additional context
No response
The text was updated successfully, but these errors were encountered: