Skip to content

Split common tests into groups #29703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adrinjalali opened this issue Aug 22, 2024 · 1 comment
Open

Split common tests into groups #29703

adrinjalali opened this issue Aug 22, 2024 · 1 comment
Labels
Developer API Third party developer API related

Comments

@adrinjalali
Copy link
Member

With #29699 we start by having two groups of tests:

  • API: the PR introduces a very basic start for this category from existing tests, but the idea is to add more here, and to properly document them in the developer guide as we go later on. This category is always ON and cannot be disabled.
  • legacy: all other tests. The idea is to move those tests into their own dedicated categories and to eventually have nothing left in legacy.

Some other categories which seem reasonable to have:

  • sample weight related tests
  • array API
  • pandas / polars / dataframe compat
  • statistical / performance tests
  • missing values
@glemaitre
Copy link
Member

I would need to see further the test but I would think that grouping sample_weight in the statistical test would make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Developer API Third party developer API related
Projects
None yet
Development

No branches or pull requests

2 participants