-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
Invariance testing for partial_fit #3896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Some possible invariance tests:
|
I didn't see this before commening on #3907. Please note that there I On 28 November 2014 at 18:25, Arnaud Joly notifications@github.com wrote:
|
This is not true: a call to fit can go do several passes over the provided until it reaches convergence on that specific piece of training data, whereas a call to |
Which is waiting for #4841 to get (completed :P) and merged. |
We have quite a few tests in common tests now for |
Much of the common functionality across estimators is tested within
sklearn.tests.test_common
. As far as I can tell, there are no tests of whatpartial_fit
should do in general, such as returningself
. (I'm not sure what else is general to all estimators supportingpartial_fit
.) Test(s) should be added.The text was updated successfully, but these errors were encountered: