Skip to content

Broken "Citing scikit-learn" link from nested documentation pages #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ogrisel opened this issue Jan 26, 2012 · 3 comments
Closed

Broken "Citing scikit-learn" link from nested documentation pages #590

ogrisel opened this issue Jan 26, 2012 · 3 comments

Comments

@ogrisel
Copy link
Member

ogrisel commented Jan 26, 2012

For instance see:

http://scikit-learn.org/stable/auto_examples/index.html

The link in the left column points to http://scikit-learn.org/stable/auto_examples/about.html#citing-scikit-learn instead of http://scikit-learn.org/stable/about.html#citing-scikit-learn
jakevdp added a commit that referenced this issue Jan 26, 2012
@jakevdp
Address Issue #590 : use relative path link to about.html
889075a
@jakevdp
Copy link
Member

jakevdp commented Jan 26, 2012

This commit should fix the issue.

@jakevdp
Copy link
Member

jakevdp commented Jan 26, 2012

Actually, I should specify: I built the docs with this commit, and the links are no longer broken.

@jakevdp jakevdp closed this as completed Jan 26, 2012
@ogrisel
Copy link
Member Author

ogrisel commented Jan 26, 2012

Ok can someone ( @fabianp ) please update both stable and dev with this fix?

satra added a commit to satra/scikit-learn that referenced this issue Jan 27, 2012
@satra
Merge remote-tracking branch 'upstream/master' into enh/metrics
c68f4f5 
* upstream/master: (823 commits)
  Set the download link to PYPI.
  Address Issue scikit-learn#590 : use relative path link to about.html
  check random state in _fit_transform
  add random_state to LocallyLinearEmbedding
  MISC: fix bibtex
  Add n_jobs option to pairwise_distances and pairwise_kernels.
  euclidian_distances is to be deprecated in v0.11.
  Better default threshold for L1-regularized models.
  Remove CoefSelectTransformerMixin and use SelectorMixin instead.
  COSMIT removed unused imports
  Cosmit: remove unused imports
  Refactor in KFold.
  COSMIT pep8
  FIX: MurmurHash3 compilation on older GCC
  DOC added required versions of python, numpy and scipy to install documentation. Closes issue scikit-learn#579
  DOC website: added link to 0.10 docs under support.
  FIX: broken build / tests
  Move preprocessing.py to sklearn/.
  preprocessing/__init__.py -> preprocessing/preprocessing.py
  ENH: Default in Vectorizer "None" as @ogrisel suggested
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ogrisel @jakevdp