Skip to content

Add fused type to Cython files #5973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
arthurmensch opened this issue Dec 7, 2015 · 4 comments
Closed

Add fused type to Cython files #5973

arthurmensch opened this issue Dec 7, 2015 · 4 comments

Comments

@arthurmensch
Copy link
Contributor

Now that we have .c files generation embedded in the build system, we can try adding fused type to various cython based module. Any thoughts on where to begin, on priorities and excepted challenges ?
@arthurmensch arthurmensch changed the title Add fuse type to Cython files Add fused type to Cython files Dec 7, 2015
@amueller
Copy link
Member

amueller commented Dec 8, 2015

the main benefit is saving memory using 32bit float, right? So we should look into algorithms that currently only have 64bit, and I guess that are commonly used? Maybe also the ones that are often memory limited? Trees are always 32 bit, SVMs are C++ anyhow and we don't want to touch. How about the neighbors trees (probably tricky)? or DBSCAN or other clustering algorithms?

@amueller
Copy link
Member

amueller commented Dec 9, 2015

see #5932

@MechCoder
Copy link
Member

Also everything related to coordinate descent uses 64 bit.

@ssaeger ssaeger mentioned this issue Feb 23, 2016
Closed
@jnothman
Copy link
Member

I consider this to replicate the wishes of #2969 and #5776, seeing as we have no other fused type use-cases so far. I am closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jnothman @amueller @MechCoder @arthurmensch