Skip to content

PR tags used in sklearn #6211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devashishd12 opened this issue Jan 22, 2016 · 9 comments
Closed

PR tags used in sklearn #6211

devashishd12 opened this issue Jan 22, 2016 · 9 comments

Comments

@devashishd12
Copy link
Contributor

I was thinking of adding a small section in the documentation telling what each tag (eg. MRG, ENH etc.) stands for and when it's used, somewhere over here. Might help beginners in scikit learn and even in other organisations for that matter.

@amueller
Copy link
Member

MRG is a tag for a PR title, ENH for a commit.
But yeah, it would be good to add them there.

@devashishd12
Copy link
Contributor Author

@amueller where exactly do you think this should go?

@ogrisel
Copy link
Member

ogrisel commented Jan 28, 2016

At the end of the contribution guide. http://scikit-learn.org/dev/developers/contributing.html

@devashishd12
Copy link
Contributor Author

Thanks! I'll do that. Actually @ogrisel I'm also working on adding #6167 in the same section. I'll add this below that and continue work in that branch only so that further problems don't arise later. Is it fine? Sorry for bothering you with another PR....

@amueller
Copy link
Member

@dsquareindia did you open a PR for this issue?

@nelson-liu
Copy link
Contributor

nelson-liu commented Sep 14, 2016

i think he was working on #6176 and was planning to put that in there (according to #6211 (comment)), but i got busy with gsoc since i last offered to take it up. i sorta forgot about it, but if this is something we want i could try wrapping it up again

@devashishd12
Copy link
Contributor Author

Hey sorry @amueller I didn't quite get around to working on this. #6411 did solve this to some extent though. #6176 seems pretty outdated now imho. Is it still needed?

@nelson-liu
Copy link
Contributor

imo the rebasing part is still quite useful, squashing not as much now that github lets you squash and commit.

@amueller
Copy link
Member

done in #7636. A link to a good rebasing doc was added in #7541. Closing this and #6176.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants