The DecisionTreeRegressor and DecisionTreeClassifier shares the fit function docstring in BaseDecisionTree.fit, how to separate the doc string?

cleanest way writes a new fit in each that calls super.

On 3 November 2016 at 01:00, alexjiang notifications@github.com wrote:

The DecisionTreeRegressor and DecisionTreeClassifier shares the fit
function docstring in BaseDecisionTree.fit, how to separate the doc
string?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#7809 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEz65is3DXkFxC5BDdC9K4rD0Igu83Tks5q6JeVgaJpZM4KmeIA
.

That's what I though. @jnothman that's not overkill, is it? I think docs are important.

not overkill, no. easier to read in the code too

On 3 November 2016 at 06:57, Andreas Mueller notifications@github.com
wrote:

That's what I though. @jnothman https://github.com/jnothman that's not
overkill, is it? I think docs are important.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#7809 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEz6-Qtud3ggGhh1TV_Ucj87EzS_WCuks5q6OsigaJpZM4KmeIA
.

Hi, I would like to take up the issue.

Should both the fit functions have any change in the docString from the one in the BaseDecisionTree.fit() function?

Please close this.