-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
Documentation issues in sklearn.datasets.fetch_kddcup99 #7861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yes it is the wrong reference (SF is not even mentioned in this ref). [2] should be: [2] K. Yamanishi, J.-I. Takeuchi, G. Williams, and P. Milne. Online |
I can submit a PR for this with the updated reference. |
@agramfort can you close this issue? |
Description
In documentation body it says the default value of parameter percent10 is False. The real value is True (which is correctly documented in the one line description in the beginning). It should be fixed.
The documentation says
However, in [2] (A Geometric Framework for Unsupervised Anomaly Detection: Detecting Intrusions in Unlabeled Data (2002) by Eleazar Eskin, Andrew Arnold, Michael Prerau, Leonid Portnoy, Sal Stolfo) they only mention that
They didn't write how they did it. Is it documented anywhere ? if it is, the proper reference should be given. Otherwise, the documentation should reference the paper only with regard to the filtering goal and not how filtering is done.
The text was updated successfully, but these errors were encountered: