Skip to content

test_kernel_ridge_singular_kernel sometimes fails on Travis #9535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
qinhanmin2014 opened this issue Aug 12, 2017 · 1 comment · Fixed by #9542
Closed

test_kernel_ridge_singular_kernel sometimes fails on Travis #9535

qinhanmin2014 opened this issue Aug 12, 2017 · 1 comment · Fixed by #9542
Labels

Comments

@qinhanmin2014
Copy link
Member

Description

When developing recently, I find that test_kernel_ridge_singular_kernel(sklearn.tests.test_kernel_ridge.test_kernel_ridge_singular_kernel) sometimes fails on Travis. The test pass after an empty commit.

Steps/Code to Reproduce

pull request #9108
failed build https://travis-ci.org/scikit-learn/scikit-learn/jobs/259750223
empty commit 2a9d47e
passed build https://travis-ci.org/scikit-learn/scikit-learn/jobs/259764708

pull request #9521
failed build https://travis-ci.org/scikit-learn/scikit-learn/jobs/263774523
empty commit 6d27fca
passed build https://travis-ci.org/scikit-learn/scikit-learn/jobs/263782780

These pull requests seem totally unrelevant to test_kernel_ridge_singular_kernel.

possible solution

(1)Reduce decimal requirement of assert_array_almost_equal from default to maybe 4-5
(2)Add a random state (may work since the errors are different and only occur sometimes, not sure)

Could you please confirm it and give me some suggestions. I'll try to fix it if the issue is valid. Thanks :)

@jnothman
Copy link
Member

jnothman commented Aug 13, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants