Skip to content

BaggingRegressor can not be used on top of pipelines that handle imputation #9708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jimmywan opened this issue Sep 7, 2017 · 3 comments
Closed

Comments

@jimmywan
Copy link
Contributor

jimmywan commented Sep 7, 2017

Description

BaggingRegressor will raise an exception:

ValueError: Input contains NaN, infinity or a value too large for dtype('float64').

I propose relaxing this constraint as the wrapped regressor should already handle checking of their input arrays. At best, the check is redundant. At worst, I can't reuse this component.

Steps/Code to Reproduce

Create pipeline that includes varying methods of imputation and wrap it with a BaggingRegressor and run it on input containing nan/infinity.

@jnothman
Copy link
Member

jnothman commented Sep 7, 2017 via email

@jimmywan
Copy link
Contributor Author

@jnothman I think PR #9707 is ready for review.

@qinhanmin2014
Copy link
Member

Resolved in #9707

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants