Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[MRG+2] Neighborhood Components Analysis #10058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG+2] Neighborhood Components Analysis #10058
Changes from all commits
849a8d8
04222de
34c5457
89f68ee
42e078a
4c7c0d4
4c81a16
824e940
d4294ac
296e295
616f9a2
12cf3a9
7b37e8d
48cab11
47928aa
4612e5f
27ab46b
44e19d6
dcb1a8a
6ba1692
03b126b
8b5646c
a7f6458
9a09e29
7721221
d5de730
173a966
2cd3bf6
c50c841
094aa97
e6daf4e
e160a6e
fbc679b
1e93e82
92faf4f
b172898
816f3de
85b2cdd
4ed68dd
1f9c208
b0a96f9
e050128
ead9850
a807df2
e00d4a1
aa90c9b
85bd54f
aa9ace7
cc07261
16cf04d
8c7af3c
8ce872f
27f2b5c
85f8d21
396f30f
8830373
16b022a
ded5ecb
648ed5f
589f57d
600adf2
d274c4a
2dbf064
e17003e
32118aa
5c2154f
cf55015
44839a0
822620d
41d3cef
faa84fc
db2950a
f16770c
4f7375e
49189c6
0fda2ca
f015bad
0e5d5b3
77dc953
a653189
be9b1e1
2b1c8f2
af14e5d
3a78d1a
58d169c
fbd28e1
8d65ebc
ed0d23a
6dbef86
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that these need either to be in a "topic", or in as footnotes: currently, they do not render right
https://48180-843222-gh.circle-artifacts.com/0/doc/modules/neighbors.html#transform
This is because the indentation is not correct.
You could remove the "topic" block, and add the following:
Where the '__________' inserts an hrule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I went for fixing the indentation, it should work like at the end of this section: https://github.com/scikit-learn/scikit-learn/blob/master/doc/modules/decomposition.rst#truncated-singular-value-decomposition-and-latent-semantic-analysis
I'll try to build the doc locally to be faster than circleci to check if it works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just saw it and it works :)