Skip to content

[MRG] MAINT do not run tests in sklearn/externals #10486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2018
Merged

[MRG] MAINT do not run tests in sklearn/externals #10486

merged 1 commit into from
Jan 17, 2018

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Jan 17, 2018

You can easily test this locally doing pytest --collect-only | grep externals.

Saw that while reviewing #10427 (comment).

@jnothman
Copy link
Member

LGTM

@lesteve
Copy link
Member Author

lesteve commented Jan 17, 2018

CIs are green, I am going to merge this one.

@lesteve lesteve merged commit ddaafa6 into scikit-learn:master Jan 17, 2018
@lesteve lesteve deleted the do-no-test-externals branch January 17, 2018 14:25
@lesteve lesteve mentioned this pull request Jan 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lesteve @jnothman