[MRG] Change image in segmentation example #10647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
did we agree on requiring skimage to build the doc? |
|
The dependency on scikit-image was introduced in #10527 after the discussion in #10502. As |
|
ok thanks for bringing me up to date :)
|
|
@agramfort Sure, no problem :) As the doc-build is finished now, here are the new images (see #10607 for the old ones): |
agramfort
approved these changes
Feb 17, 2018
jnothman
approved these changes
Feb 18, 2018
wdevazelhes
added a commit
to wdevazelhes/scikit-learn
that referenced
this pull request
Feb 20, 2018
This reverts commit cf9c67e.
|
The skimage doc dependency is not documented, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #10607
What does this implement/fix? Explain your changes.
This replaces the racoon face used in the image segmentation examples. It does not have sharp boundaries and thus the resulting segmentation is not very instructive (see #10607 for images). As scikit-image is already a dependency for these two examples,
skimage.data.coinsis used instead. Due to the sharper boundaries the results correctness can be judged much more intuitively. (I'll add the links to the images as soon as the build is done.)