Skip to content

[MRG+1] DOC note change in StratifiedKFold shuffle in 0.19 #10768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 7, 2018
Merged

[MRG+1] DOC note change in StratifiedKFold shuffle in 0.19 #10768

merged 2 commits into from
Mar 7, 2018

Conversation

jnothman
Copy link
Member

@jnothman jnothman commented Mar 7, 2018

Fixes #10274

qinhanmin2014
qinhanmin2014 approved these changes Mar 7, 2018
View reviewed changes
Copy link
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinhanmin2014 qinhanmin2014 changed the title DOC note change in Stratified K Fold shuffle in 0.19 [MRG+1] DOC note change in StratifiedKFold shuffle in 0.19 Mar 7, 2018
@qinhanmin2014
Copy link
Member

I'm OK to merge as it is but I might prefer more details about the backwards incompatibility (maybe a what's new entry mentioning e.g., we now directly use the random state provided by the user; and a link to #7823)

@jnothman
Copy link
Member Author

jnothman commented Mar 7, 2018 via email

@qinhanmin2014 qinhanmin2014 merged commit ccbf997 into scikit-learn:master Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinhanmin2014 qinhanmin2014 qinhanmin2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jnothman @qinhanmin2014