[MRG] Wording in roc crossval example #10820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace "Luck" by "Chance" on the crossvalidation example as it sounds better in English.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
I am not aware of an issue.
What does this implement/fix? Explain your changes.
Replaces the term "Luck" in the graph by "Chance", as it is more correct.
Any other comments?
This is a small PR in order to see how the process works, this was advised by @glemaitre .
I could not make the tests pass as referenced in #10562, however the failing tests have nothing to
do with the changed code (which is obvious since the change is ridiculously small and irrelevant to the rest of the code).