[MRG+2] Invariance tests for clustering metrics #10828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3rd version
Added format invariance and changed label permutation tests
…Added fowlkes_mallows and calinsky_harabaz . Removed the groups for permute_labels and invariance_format
remove outdated comment
|
I do like the idea of those tests, but I don't mind them being added after this is merged. |
jnothman
reviewed
Mar 18, 2018
doc/whats_new/v0.20.rst
Outdated
| @@ -492,3 +492,6 @@ Changes to estimator checks | |||
| - Add test :func:`estimator_checks.check_methods_subset_invariance` to check | |||
| that estimators methods are invariant if applied to a data subset. | |||
| :issue:`10420` by :user:`Jonathan Ohayon <Johayon>` | |||
|
|
|||
| - Add invariance tests for clustering metrics. :issue:`8102` by :user:`Ankita | |||
| Sinha <anki08>` and `Guillaume Lemaitre <glemaitre>`. | |||
There was a problem hiding this comment.
You either need :user: or you need to add yourself to _contributors.rst and use `Guillaume Lemaitre`_
jnothman
approved these changes
Mar 18, 2018
|
I would merge for now to not block the other PR. I will try to submit a PR once I fixed the SimpleImputer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8135
closes #8102
Take over #8135 by using pytest feature to simplify the tests.
To be discussed:
@jnothman Let me know if we address the above 2 points or this is not necessary.