[WIP] New Feature: Add AverageRegressor #10868
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jnothman
reviewed
Mar 25, 2018
| ' tuples') | ||
|
|
||
| # validate that at least one estimator is not None | ||
| isnone = [clf is not None for _, clf in self.estimators] |
There was a problem hiding this comment.
Can't we avoid duplication with respect to VotingClassifier?
jnothman
reviewed
Mar 25, 2018
|
@jnothman Thanks for reviewing, I refactored the code to |
|
is this still wip?
|
jnothman
reviewed
Apr 9, 2018
|
@jnothman it's still WIP because I haven't finished the examples and the documentation update. Also, I am still not fully happy with the state of the code right now, I need to reduce the amount of duplicated code as much as possible before switching to MRG. But If you have any other suggestion or comments, that would be helpful. Thanks |
|
Do you plan to complete this PR? |
|
@stsouko yes, I'll spare few hours this week to finish it. |
6 tasks
|
Closed by #12513 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #10743
What does this implement/fix? Explain your changes.
Following @amueller suggestion about adding
sklearn.ensemble.AverageRegressor, this PR implements:Any other comments?
This PR is inspired from work on
bagging.py,VotingClassifierand their associated unit-tests.