Skip to content

[MRG] Fix Document the "warm restarts trick" #9294 #11279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2018
Merged

[MRG] Fix Document the "warm restarts trick" #9294 #11279

merged 1 commit into from
Jun 15, 2018

Conversation

tsdlovell
Copy link
Contributor

Reference Issues/PRs

Fixes #9294

What does this implement/fix? Explain your changes.

Replace TODO in performance.html with link to the glossary definition of warm_restart

@amueller
Copy link
Member

Maybe also add links to the warm_start parameter in the models that have it?

@tsdlovell
Copy link
Contributor Author

via See also or Notes or something else?

@tsdlovell
Copy link
Contributor Author

ah, I think I see how.

Like in GaussianProcessClassifier

See :term:`the Glossary <warm_start>`.

@tsdlovell
Copy link
Contributor Author

tsdlovell commented Jun 15, 2018 •
edited
Loading

Its looks like it is already the case that models that accept a warm_start parameter have a reference to the glossary.
I looked for all files that matched git grep -l 'warm_start[[:space:]]*:', and checked the docs for that parameter. Does that seem like a reasonably exhaustive check?

@amueller amueller merged commit 93320a9 into scikit-learn:master Jun 15, 2018
georgipeev pushed a commit to georgipeev/scikit-learn that referenced this pull request Jun 20, 2018
@tsdlovell
DOC: replace TODO with link to the glossary (scikit-learn#11279)
47891de 
Fixes scikit-learn#9294
@amueller amueller mentioned this pull request Aug 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomDLT TomDLT TomDLT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document the "warm restarts trick"
3 participants
@tsdlovell @amueller @TomDLT