[WIP] fix PEP8 issues in sklearn/ensemble/* #11322
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @lasagnaman for the PR. We have decided not to fix existing PEP8 errors. See #9171. |
|
ha, sure thing. Do you think it makes sense to add a comment to the Contribution Guidelines to make this explicit, or is it acceptable for someone to play police whenever someone submits a PR like this? I have no horse in this race, but I'm happy to submit a PR for the guidelines if you think it's appropriate. |
|
a comment in the guidelines would be welcome. Basically note that cosmetic
changes cause unhelpful merge conflicts for existing PRs.
Also note that in the context of a feature PR, unrelated changes make the
feature hard to review.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Resolve PEP8 issues in sklearn/ensemble/*
Any other comments?
Was previously part of #11280