[MRG] FIX: Ensure dictionary is writeable #11342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the `dictionary` in `dict_learning_online` can be supplied by the user and we intend to write to it, ensure that it is writable before proceeding. This is needed as `dict_learning_online` will overwrite data in `dictionary` as it runs.
4bdf305 to
f4547a8
Compare
Add a new test based on an existing one with a user provided dictionary to ensure that if the array is read-only, `dict_learning_online` will turn it into a writable array (copying if needed). Without the fix included this test will fail by trying to write to the dictionary, which is read-only due to the initialization condition.
f4547a8 to
0104261
Compare
|
LGTM but I wonder if we should have a more general approach to this? I would say not necessarily as it's here a function that is updated and not an estimator. |
agramfort
approved these changes
Jun 22, 2018
|
It might be worth adding copying parameters if that is what you mean. Though in some cases copying happens anyways. So they would act more like suggestions than requirements. Given this case just failed, opted to just fix the bug without altering existing behavior. |
jnothman
approved these changes
Jun 23, 2018
|
Thanks @jakirkham |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the
dictionaryindict_learning_onlinecan be supplied by the user and we intend to write to it, ensure that it is writable before proceeding. This is needed asdict_learning_onlinewill overwrite data indictionaryas it runs. Tweak an existing test to initializedict_learning_onlinewith a read-onlydictionaryand ensure it will reach code that tries to write to the read-onlydictionary(unless we ensure it is writeable).