Skip to content

[MRG] Feature agglomeration deprecation fix #11537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 16, 2018
Merged

[MRG] Feature agglomeration deprecation fix #11537

merged 2 commits into from
Jul 16, 2018

Conversation

amueller
Copy link
Member

Right now using feature agglomeration raises a deprecation warning. It shouldn't.

@amueller amueller changed the title Feature agglomeration deprecation fix [MRG] Feature agglomeration deprecation fix Jul 15, 2018
@amueller amueller added this to the 0.20 milestone Jul 15, 2018
@glemaitre
Copy link
Member

LGTM

lesteve
lesteve reviewed Jul 15, 2018
View reviewed changes
Copy link
Member

@lesteve lesteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch!

I have some memory that the check was done in the constructor at the beginning (so probably it was working originally) and then moved to fit.

@amueller
Copy link
Member Author

let's see if it passes, locally I had some weird numpy binary mismatch error and I'm rebuilding.

@amueller amueller mentioned this pull request Jul 15, 2018
Merged
@amueller
Copy link
Member Author

@lesteve I figure you wanted to approve?

@glemaitre
Copy link
Member

he did :)

qinhanmin2014
qinhanmin2014 approved these changes Jul 16, 2018
View reviewed changes
Copy link
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinhanmin2014 qinhanmin2014 merged commit 0caa548 into scikit-learn:master Jul 16, 2018
@thomasjpfan thomasjpfan mentioned this pull request Mar 15, 2022
Closed
@ShanDeng123 ShanDeng123 mentioned this pull request Mar 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesteve lesteve lesteve left review comments

@glemaitre glemaitre glemaitre approved these changes

@qinhanmin2014 qinhanmin2014 qinhanmin2014 approved these changes

Assignees
No one assigned
Labels
Blocker
Projects
None yet
Milestone
0.20
Development

Successfully merging this pull request may close these issues.
4 participants
@amueller @glemaitre @lesteve @qinhanmin2014