raise DeprecationWarnings and FutureWarnings as errors #11570

amueller · 2018-07-16T20:57:12Z

Towards #11252.
In the end we'd like to make these errors so we can keep this cleaner in the future.

…e names. this is already tested for strings. Could add a test for dtype object?

amueller · 2018-07-16T22:34:35Z

this should be everything except model_selection and isolation forest and bagging which uses Imputer (these two have separate issues).

amueller · 2018-07-17T14:59:32Z

merged #11593 into this so tests may pass.

rth · 2018-07-17T15:35:00Z

sklearn/linear_model/tests/test_least_angle.py

@@ -473,6 +473,7 @@ def test_lars_path_readonly_data():
        _lars_path_residues(X_train, y_train, X_test, y_test, copy=False)


+@ignore_warnings(DeprecationWarning)  # positive deprecated, remove in 0.22


This will skip the test due to #11594 (also applies to all other tests)

rth · 2018-07-17T15:35:44Z

sklearn/model_selection/tests/test_search.py

@@ -1,20 +1,21 @@
 """Test the search module"""

+from collections import Iterable, Sized


from sklearn.utils.fixes import _Iterable as Iterable, _Sized as Sized

otherwise we get collections ABC warning in Python 3.7

ah, right. not sure why @janvanrijn changed that.

My code is an (old) version of master. I did not intentionally change that

ah, that makes sense.

rth · 2018-07-17T15:36:46Z

sklearn/model_selection/tests/test_search.py


 import numpy as np
 import scipy.sparse as sp
 import pytest

 from sklearn.utils.fixes import sp_version
 from sklearn.utils.fixes import PY3_OR_LATER
-from sklearn.utils.fixes import _Iterable as Iterable, _Sized as Sized


Why? That's necessary to avoid warnings in Python 3.7

rth · 2018-07-17T15:48:23Z

I think we need need to test Python 3.7 in Travis and not in a cron job (#11409). Otherwise this would have failed on Python 3.7 but we won't know because we are not testing for it..

amueller · 2018-07-17T15:52:02Z

@rth we should but that seems unrelated ;)

rth · 2018-07-17T15:54:57Z

@amueller you are right.

massich · 2018-07-17T16:18:47Z

Apart from what @lesteve had catch in #11594 the rest LGTM.

before 0.20 is not the time, but I would give a try to a decorator that catches deprecation and future warnings, ignore them when the version is in range and errors otherwise. I'm sure I did some steps towards that but I cannot find where.

amueller · 2018-07-17T18:45:09Z

I attempted the thing @massich is mentioning in github.com/amueller/futurepast but didn't have the follow-through necessary

massich · 2018-07-17T20:11:53Z

sklearn/preprocessing/tests/test_function_transformer.py

@@ -75,6 +76,7 @@ def test_delegate_to_func():
    )


+@ignore_warnings(FutureWarning)  # ignore warning for validate=False 0.22


@ignore_warnings(category=FutureWarning)

amueller added 2 commits July 16, 2018 15:56

raise DeprecationWarnings and FutureWarnings as errors

c3af3e2

fix deprecation warnings in utils

3cb2cf5

albertcthomas mentioned this pull request Jul 16, 2018

[MRG + 1] Novelty detection with LocalOutlierFactor #11569

Closed

amueller added 3 commits July 16, 2018 16:09

fix preprocessing deprecation/future warnings

6d04e8b

skip LSH tests because deprecated

6409f29

deprecations in neighbors module

85f910f

amueller mentioned this pull request Jul 16, 2018

regression AUC reorder? #11572

Closed

amueller added 5 commits July 16, 2018 16:37

pass max_iter to PAClassifier

3f4a6d2

lars positive deprecated

2fb0b97

randomized lasso deprecated

477ca01

gridsearch cv iid in ridge tests

eb92a69

more linear model deprecations

e0bc687

amueller mentioned this pull request Jul 16, 2018

[MRG+1] Fix #10229: check_array should fail if array has strings #10495

Merged

amueller added 6 commits July 16, 2018 16:57

pass through dtypes when filtering columns so we can transform featur…

506cf6d

…e names. this is already tested for strings. Could add a test for dtype object?

catch scipy face deprecation warnings

b12b9fb

catch gridsearch deprecation warnings in text feature extraction

f0bd420

remove some deprecation warnings from ensemble module

5a106d2

decomposition deprecations caught

4af1f20

fix deprecation test in covariance

d93115d

amueller added this to the 0.20 milestone Jul 16, 2018

amueller added the Blocker label Jul 16, 2018

filter iid warning

679568c

amueller mentioned this pull request Jul 16, 2018

cross_validate and cross_val_score raise errors_score warning but don't expose it #11576

Closed

amueller added 5 commits July 16, 2018 18:11

catch warnings in model selection

2daad09

skip more deprecations in model selection

b18d3cf

ignore reorder warning, not sure if it's the right thing to do.

248d9ad

more iid warnings

7e8b259

bagging iid fix

96feb0f

amueller mentioned this pull request Jul 17, 2018

[NOMRG] TST Use SimpleImputer instead of Imputer in test_bagging.py #11480

Closed

Merge branch 'simpleimputer_bagging' into test_warnings

de984dd

amueller mentioned this pull request Jul 17, 2018

[MRG+1] TST Ignore DeprecationWarning in test_auc_duplicate_values #11580

Closed

amueller added 3 commits July 17, 2018 10:06

add version to deprecation warning comment so we can git grep for it

15bf683

ignore iid warning instead of passing iid=False

56dbf07

fix warning test

db01626

rth reviewed Jul 17, 2018

View reviewed changes

fix calls to ignore_warnings

5c1b4f3

add missing pytest imports

0afd1e5

don't specify rcond for old numpy, fix deprecation test

0718707

amueller added 7 commits July 17, 2018 14:14

remove duplicate test

e7f4602

fix collections Mapping import

68ea022

hotfixes for scipy atol and botched _fit_and_score

3ac41dc

actually fix abc warning, also fix randomized lasso deprecation catch

e52175c

Merge branch 'master' into test_warnings

cf81437

catch vmeasure warnings

14ec4f3

random forest n_estimator deprecations

6a25eb4

massich reviewed Jul 17, 2018

View reviewed changes

amueller added 4 commits July 17, 2018 15:14

add category to ignore_warning(FutureWarnings)

9e59ba2

ignore matplotlib warnings

df339f6

catch nmi warnings in spectral embedding tests

642b6ac

ami nmi deprecation warnings caught

022907a

amueller merged commit 8e2c2aa into scikit-learn:master Jul 17, 2018

amueller mentioned this pull request Jul 17, 2018

Review DeprecationWarnings and FutureWarnings in raise tests for the 0.20 release #11252

Closed

amueller mentioned this pull request Aug 5, 2019

Further reduce the number of warnings in testing #11240

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

raise DeprecationWarnings and FutureWarnings as errors #11570

raise DeprecationWarnings and FutureWarnings as errors #11570

amueller commented Jul 16, 2018

amueller commented Jul 16, 2018

amueller commented Jul 17, 2018

rth Jul 17, 2018 •

edited

Loading

rth Jul 17, 2018

amueller Jul 17, 2018

janvanrijn Jul 17, 2018

amueller Jul 17, 2018

rth Jul 17, 2018

rth commented Jul 17, 2018

amueller commented Jul 17, 2018

rth commented Jul 17, 2018

massich commented Jul 17, 2018

amueller commented Jul 17, 2018

massich Jul 17, 2018

		@@ -473,6 +473,7 @@ def test_lars_path_readonly_data():
		_lars_path_residues(X_train, y_train, X_test, y_test, copy=False)


		@ignore_warnings(DeprecationWarning) # positive deprecated, remove in 0.22

		@@ -1,20 +1,21 @@
		"""Test the search module"""

		from collections import Iterable, Sized

		@@ -75,6 +76,7 @@ def test_delegate_to_func():
		)


		@ignore_warnings(FutureWarning) # ignore warning for validate=False 0.22

raise DeprecationWarnings and FutureWarnings as errors #11570

raise DeprecationWarnings and FutureWarnings as errors #11570

Conversation

amueller commented Jul 16, 2018

amueller commented Jul 16, 2018

amueller commented Jul 17, 2018

rth Jul 17, 2018 • edited Loading

Choose a reason for hiding this comment

rth Jul 17, 2018

Choose a reason for hiding this comment

amueller Jul 17, 2018

Choose a reason for hiding this comment

janvanrijn Jul 17, 2018

Choose a reason for hiding this comment

amueller Jul 17, 2018

Choose a reason for hiding this comment

rth Jul 17, 2018

Choose a reason for hiding this comment

rth commented Jul 17, 2018

amueller commented Jul 17, 2018

rth commented Jul 17, 2018

massich commented Jul 17, 2018

amueller commented Jul 17, 2018

massich Jul 17, 2018

Choose a reason for hiding this comment

rth Jul 17, 2018 •

edited

Loading