Skip to content

[MRG+2] FIX: make the deprecation in fit and not init in IsolationForest #11574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 17, 2018
Merged

[MRG+2] FIX: make the deprecation in fit and not init in IsolationForest #11574

merged 3 commits into from
Jul 17, 2018

Conversation

glemaitre
Copy link
Member

closes #11573

Rework IsolationForest issue

  • Change DeprecationWarning by a FutureWarning
  • Raise the warning into fit instead than init

@glemaitre glemaitre added this to the 0.20 milestone Jul 16, 2018
@amueller
Copy link
Member

looks good

qinhanmin2014
qinhanmin2014 approved these changes Jul 17, 2018
View reviewed changes
Copy link
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update the docstring of contamination

@albertcthomas
Copy link
Contributor

LGTM. Thanks @glemaitre. Travis failure does not seem to be related to this PR.

TomDLT
TomDLT approved these changes Jul 17, 2018
View reviewed changes
Copy link
Member

@TomDLT TomDLT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update the docstring of contamination

+1

@glemaitre
Copy link
Member Author

What do you mean by updating the docstring

@qinhanmin2014
Copy link
Member

Seems that the docstring of parameter contamination fails to mention the change.

@glemaitre
Copy link
Member Author

glemaitre commented Jul 17, 2018 via email

qinhanmin2014
qinhanmin2014 approved these changes Jul 17, 2018
View reviewed changes
Copy link
Member

@qinhanmin2014 qinhanmin2014 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CIs are green, thanks @glemaitre

@qinhanmin2014 qinhanmin2014 changed the title [MRG] FIX: make the deprecation in fit and not init in IsolationForest [MRG+2] FIX: make the deprecation in fit and not init in IsolationForest Jul 17, 2018
@glemaitre glemaitre changed the title [MRG+2] FIX: make the deprecation in fit and not init in IsolationForest [NOMRG] FIX: make the deprecation in fit and not init in IsolationForest Jul 17, 2018
@glemaitre
Copy link
Member Author

We cannot merge this PR now. There is a strange side effect with ignore_warning and filterwarnings I think.

@glemaitre glemaitre changed the title [NOMRG] FIX: make the deprecation in fit and not init in IsolationForest [MRG+2] FIX: make the deprecation in fit and not init in IsolationForest Jul 17, 2018
@glemaitre
Copy link
Member Author

Ok it passed on my forked CI

@glemaitre
Copy link
Member Author

FYI: https://travis-ci.org/glemaitre/scikit-learn/builds/404971390

lesteve
lesteve reviewed Jul 17, 2018
View reviewed changes
sklearn/linear_model/tests/test_sag.py
@@ -269,7 +270,6 @@ def test_classifier_matching():
assert_array_almost_equal(intercept2, clf.intercept_, decimal=9)


@ignore_warnings
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really do not get this weird side-effect at a distance kind of thing ... it feels like something is really fishy here. I'll try to reproduce locally.

@amueller
Copy link
Member

travis passes. should we wait for the rest?

@glemaitre glemaitre mentioned this pull request Jul 17, 2018
Merged
@amueller amueller merged commit cba99e0 into scikit-learn:master Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesteve lesteve lesteve left review comments

@amueller amueller amueller approved these changes

@TomDLT TomDLT TomDLT approved these changes

@qinhanmin2014 qinhanmin2014 qinhanmin2014 approved these changes

@albertcthomas albertcthomas albertcthomas approved these changes

Assignees
No one assigned
Labels
Blocker
Projects
None yet
Milestone
0.20
Development

Successfully merging this pull request may close these issues.

IsolationForest contamination deprecation in __init__ not in fit
6 participants
@glemaitre @amueller @albertcthomas @qinhanmin2014 @lesteve @TomDLT