Skip to content

TST: remove ignorewarning and introduce specific filterwarning in SAG #11606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 19, 2018
Merged

TST: remove ignorewarning and introduce specific filterwarning in SAG #11606

merged 2 commits into from
Jul 19, 2018

Conversation

glemaitre
Copy link
Member

It should remove the failure from test_sag

@jorisvandenbossche jorisvandenbossche mentioned this pull request Jul 17, 2018
Merged
jnothman
jnothman approved these changes Jul 18, 2018
View reviewed changes
Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much more readable!!

@agramfort
Copy link
Member

@glemaitre please rebase to restart CIs

@glemaitre
Copy link
Member Author

@agramfort Done and the test are passing

rth
rth approved these changes Jul 19, 2018
View reviewed changes
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! We should open an issue about generally preferring this approach to ignore_warnings..

@rth rth merged commit 2489035 into scikit-learn:master Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman approved these changes

@rth rth rth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@glemaitre @agramfort @jnothman @rth