Skip to content

[MRG+2] TST Using default rtol in test sample_weight invariance #11621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2018
Merged

[MRG+2] TST Using default rtol in test sample_weight invariance #11621

merged 1 commit into from
Jul 18, 2018

Conversation

sergulaydore
Copy link
Contributor

Reference Issues/PRs

Changes the rtol in #11558 from 0.5 to default based on #11558 (comment)

What does this implement/fix? Explain your changes.

Makes the test for sample_weight invariance more reliable.

@sergulaydore sergulaydore mentioned this pull request Jul 18, 2018
Merged
TomDLT
TomDLT approved these changes Jul 18, 2018
View reviewed changes
Copy link
Member

@TomDLT TomDLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better, thanks

qinhanmin2014
qinhanmin2014 approved these changes Jul 18, 2018
View reviewed changes
Copy link
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @sergulaydore. Happy to merge when CIs are green.

@qinhanmin2014 qinhanmin2014 changed the title using default rtol in test sample_weight invariance [MRG] TST Using default rtol in test sample_weight invariance Jul 18, 2018
@qinhanmin2014 qinhanmin2014 added this to the 0.20 milestone Jul 18, 2018
@qinhanmin2014 qinhanmin2014 changed the title [MRG] TST Using default rtol in test sample_weight invariance [MRG+2] TST Using default rtol in test sample_weight invariance Jul 18, 2018
@GaelVaroquaux
Copy link
Member

Thanks a lot, @sergulaydore! Merging

@GaelVaroquaux GaelVaroquaux merged commit 4fd7332 into scikit-learn:master Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomDLT TomDLT TomDLT approved these changes

@qinhanmin2014 qinhanmin2014 qinhanmin2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.20
Development

Successfully merging this pull request may close these issues.
4 participants
@sergulaydore @GaelVaroquaux @TomDLT @qinhanmin2014