-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
[MRG+2] BUG: do not call fit twice in TransformedTargetetRegressor #11641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
020331b
BUG: do not call fit if the check_inverse is False in TransformedTarg…
glemaitre a7cb9d3
right fix
glemaitre 1b186e7
Merge remote-tracking branch 'origin/master' into is/11618
glemaitre cb2c75e
nitpicks
glemaitre 839790d
TST: add regression test
glemaitre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -265,3 +265,31 @@ def test_transform_target_regressor_ensure_y_array(): | |
tt.predict(X.tolist()) | ||
assert_raises(AssertionError, tt.fit, X, y.tolist()) | ||
assert_raises(AssertionError, tt.predict, X) | ||
|
||
|
||
class DummyTransformer(BaseEstimator, TransformerMixin): | ||
"""Dummy transformer which count how many time fit was called.""" | ||
def __init__(self, fit_counter=0): | ||
self.fit_counter = fit_counter | ||
|
||
def fit(self, X, y=None): | ||
self.fit_counter += 1 | ||
return self | ||
|
||
def transform(self, X): | ||
return X | ||
|
||
def inverse_transform(self, X): | ||
return X | ||
|
||
|
||
@pytest.mark.parametrize("check_inverse", [False, True]) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe we only need to test |
||
def test_transform_target_regressor_count_fit(check_inverse): | ||
# regression test for gh-issue #11618 | ||
# check that we only call a single time fit for the transformer | ||
X, y = friedman | ||
ttr = TransformedTargetRegressor( | ||
transformer=DummyTransformer(), check_inverse=check_inverse | ||
) | ||
ttr.fit(X, y) | ||
assert ttr.transformer_.fit_counter == 1 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving the following block to up a few lines so it follows
self._fit_transformer(y_2d)
would make it easier to follow howy
transforms.