Skip to content

[WIP] EHN: Ridge with solver SAG/SAGA does not cast to float64 #11643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

glemaitre
Copy link
Member

@glemaitre glemaitre commented Jul 20, 2018

closes #11642

build upon #11155

TODO:

Joan Massich and others added 13 commits July 8, 2018 15:46
initial PR commit

seq_dataset.pyx generated from template

seq_dataset.pyx generated from template #2

rename variables

fused types consistency test for seq_dataset

a

sklearn/utils/tests/test_seq_dataset.py

new if statement

add doc

sklearn/utils/seq_dataset.pyx.tp

minor changes

minor changes

typo fix

check numeric accuracy only up 5th decimal

Address oliver's request for changing test name

add test for make_dataset and rename a variable in test_seq_dataset
@glemaitre glemaitre changed the title EHN: Ridge with solver SAG/SAGA does not cast to float64 [WIP] EHN: Ridge with solver SAG/SAGA does not cast to float64 Jul 20, 2018
@GaelVaroquaux
Copy link
Member

This is superseeded and should be closed, no?

@jnothman jnothman closed this Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ridge with SAG/SAGA should not cast to float 64
5 participants