Skip to content

Bump default tol to 0.001 in liblinear calls for LinearSV{C,R} #11653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Bump default tol to 0.001 in liblinear calls for LinearSV{C,R} #11653

wants to merge 1 commit into from

Conversation

samronsin
Copy link
Contributor

Reference Issues/PRs

See #11536

What does this implement/fix? Explain your changes.

Any other comments?

@samronsin samronsin changed the title Bump tol to 0.001 in liblinear calls for LinearSV{C,R} Bump default tol to 0.001 in liblinear calls for LinearSV{C,R} Jul 21, 2018
@amueller
Copy link
Member

I think we should actually use the solver-specific logic implemented in liblinear.

@amueller
Copy link
Member

amueller commented Aug 5, 2019

closing

@amueller amueller closed this Aug 5, 2019
@sturlamolden sturlamolden mentioned this pull request Mar 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samronsin @amueller