Skip to content

[MRG] FIX IndexError due to imprecision in KMeans++ #11756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2019
Merged

[MRG] FIX IndexError due to imprecision in KMeans++ #11756

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff859ef
FIX IndexError due to imprecision in KMeans++
jnothman Aug 6, 2018
69d93f5
Fix silly error
jnothman Aug 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sklearn/cluster/k_means_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,9 @@ def _k_init(X, n_clusters, x_squared_norms, random_state, n_local_trials=None):
rand_vals = random_state.random_sample(n_local_trials) * current_pot
candidate_ids = np.searchsorted(stable_cumsum(closest_dist_sq),
rand_vals)
# XXX: numerical imprecision can result in a candidate_id out of range
np.clip(candidate_ids, None, closest_dist_sq.size - 1,
out=candidate_ids)

# Compute distances to center candidates
distance_to_candidates = euclidean_distances(
Expand Down